Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed #2445

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 3, 2024

I omit the test from this change.
The test heavily depends on features only available in 21.
I tried to get it working in 20 because that has virtual threads,
but there are more things missing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280113 needs maintainer approval

Issue

  • JDK-8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2445/head:pull/2445
$ git checkout pull/2445

Update a local copy of the PR:
$ git checkout pull/2445
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2445

View PR using the GUI difftool:
$ git pr show -t 2445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2445.diff

Webrev

Link to Webrev Comment

@GoeLin GoeLin marked this pull request as draft May 3, 2024 14:49
@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 3, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 5a3c668: 8272315: Improve assert_different_registers
  • e974897: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
  • d2982c6: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
  • 68a2d93: 8330094: RISC-V: Save and restore FRM in the call stub
  • 32bf1f4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b6ecca126846f9c53d554ff061cfe9b7b20a4d12 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 3, 2024
@GoeLin GoeLin marked this pull request as ready for review May 8, 2024 08:37
@openjdk
Copy link

openjdk bot commented May 8, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 8, 2024
@mlbridge
Copy link

mlbridge bot commented May 8, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 8, 2024
@GoeLin
Copy link
Member Author

GoeLin commented May 10, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2024

Going to push as commit 4504b16.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 97cc177: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • e552509: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
  • 5a3c668: 8272315: Improve assert_different_registers
  • e974897: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
  • d2982c6: 8331641: [17u]: Bump GHA bootstrap JDK to 17.0.11
  • 68a2d93: 8330094: RISC-V: Save and restore FRM in the call stub
  • 32bf1f4: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2024
@openjdk openjdk bot closed this May 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

@GoeLin Pushed as commit 4504b16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8280113 branch May 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants