-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed #2445
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit 4504b16.
Your commit was automatically rebased without conflicts. |
I omit the test from this change.
The test heavily depends on features only available in 21.
I tried to get it working in 20 because that has virtual threads,
but there are more things missing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2445/head:pull/2445
$ git checkout pull/2445
Update a local copy of the PR:
$ git checkout pull/2445
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2445/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2445
View PR using the GUI difftool:
$ git pr show -t 2445
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2445.diff
Webrev
Link to Webrev Comment