-
Notifications
You must be signed in to change notification settings - Fork 228
8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
/integrate |
Going to push as commit 4b40f90. |
I backport this for parity with 17.0.17-oracle.
the change itself applied clean. The tests needed some
changes to work:
test/jdk/java/net/httpclient/CancelStreamedBodyTest.java
A new test that lacks the changes of later change JDK-8295944
that was already backported.
test/jdk/java/net/httpclient/SmallTimeout.java
The test calls close() of ExecutorService which is a method
introduced after jdk17. I implemented the functionality
locally in the test.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3669/head:pull/3669
$ git checkout pull/3669
Update a local copy of the PR:
$ git checkout pull/3669
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3669/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3669
View PR using the GUI difftool:
$ git pr show -t 3669
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3669.diff
Using Webrev
Link to Webrev Comment