Skip to content

8272167: AbsPathsInImage.java should skip *.dSYM directories #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 27, 2021

Hi all,
This pull request contains a backport of commit dd93c6e2 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 12 Oct 2021 and was reviewed by Magnus Ihse Bursie and Erik Joelsson.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272167: AbsPathsInImage.java should skip *.dSYM directories

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/37.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dd93c6e27b66acebb221583fd28d03c65bfc1f24 8272167: AbsPathsInImage.java should skip *.dSYM directories Dec 27, 2021
@openjdk
Copy link

openjdk bot commented Dec 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Dec 27, 2021
@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Dec 27, 2021
@openjdk
Copy link

openjdk bot commented Dec 27, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272167: AbsPathsInImage.java should skip *.dSYM directories

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 27, 2021
@mrserb mrserb marked this pull request as ready for review December 27, 2021 22:00
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2021

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2021

Going to push as commit dcd9821.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 493a78a: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • f016e60: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • 3adb3dd: 8278099: two sun/security/pkcs11/Signature tests failed with AssertionError
  • 38fdf4f: 8276623: JDK-8275650 accidentally pushed "out" file
  • d30b6e4: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
  • 6aa60ac: 8277441: CompileQueue::add fails with assert(_last->next() == __null) failed: not last
  • 15f2406: 8274714: Incorrect verifier protected access error message
  • 4a38659: 8274658: ISO 4217 Amendment 170 Update
  • 5287dae: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2021
@openjdk openjdk bot closed this Dec 29, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@mrserb Pushed as commit dcd9821.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant