-
Notifications
You must be signed in to change notification settings - Fork 224
8278627: Shenandoah: TestHeapDump test failed #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278627: Shenandoah: TestHeapDump test failed #58
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
||
void ShenandoahHeapIterationRootScanner::roots_do(OopClosure* oops) { | ||
// Must use _claim_other to avoid interfering with concurrent CLDG iteration | ||
CLDToOopClosure clds(oops, ClassLoaderData::_claim_other); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused a bit. The original code for 17u has ClassLoaderData::_claim_none
here, the backport changes it to _claim_other
. The JDK 18 had _claim_other
both in original code and in the patch. What is going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! _claim_other comes from JDK-8273559. I tried to backport JDK-8273559 as well, but ran into lock rank inversion problem, as grand lock rank reshuffling is not in JDK17u.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit e54e3c4.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit e54e3c4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport this patch to 17u, it fixes a potential fatal crash during heap dump.
The original patch does not apply cleanly, due to context differences, e.g. JDK-8273559 and JDK-8268368 do not in 17u.
Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/58/head:pull/58
$ git checkout pull/58
Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/58/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 58
View PR using the GUI difftool:
$ git pr show -t 58
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/58.diff