Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288399: MacOS debug symbol files not always deterministic in reproducible builds #624

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Aug 2, 2022

On MacOS builds enable -fdebug-prefix-map and -frandom-seed to enable fully reproducible builds, that are currently non-deterministic when debug symbols are created due to absolute debug symbol paths and non-deterministic random symbol name generation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288399: MacOS debug symbol files not always deterministic in reproducible builds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/624/head:pull/624
$ git checkout pull/624

Update a local copy of the PR:
$ git checkout pull/624
$ git pull https://git.openjdk.org/jdk17u-dev pull/624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 624

View PR using the GUI difftool:
$ git pr show -t 624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/624.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6633855ca78ff0f5f1213a2a1424436678a30e55 8288399: MacOS debug symbol files not always deterministic in reproducible builds Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288399: MacOS debug symbol files not always deterministic in reproducible builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

  • 9168aa2: 8289549: ISO 4217 Amendment 172 Update
  • bb31cd9: 8283277: ISO 4217 Amendment 171 Update
  • b284851: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • 1fe8777: 8285693: Create an automated test for JDK-4702199
  • 6bfe87d: 8284077: Create an automated test for JDK-4170173
  • 91b5c0a: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • 951fff5: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • c430a94: 8291595: [17u] Delete files missed in backport of 8269039
  • 5885a8e: 8283624: Create an automated regression test for RFE-4390885
  • 53cb002: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • ... and 65 more: https://git.openjdk.org/jdk17u-dev/compare/bd7766321b2530d77835ca77e4b819cee6831a3f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

@andrew-m-leonard
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@andrew-m-leonard
Your change (at version 38488f9) is now ready to be sponsored by a Committer.

@adinn
Copy link
Contributor

adinn commented Aug 8, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 8, 2022

Going to push as commit f74269c.
Since your change was applied there have been 75 commits pushed to the master branch:

  • 9168aa2: 8289549: ISO 4217 Amendment 172 Update
  • bb31cd9: 8283277: ISO 4217 Amendment 171 Update
  • b284851: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism
  • 1fe8777: 8285693: Create an automated test for JDK-4702199
  • 6bfe87d: 8284077: Create an automated test for JDK-4170173
  • 91b5c0a: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
  • 951fff5: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • c430a94: 8291595: [17u] Delete files missed in backport of 8269039
  • 5885a8e: 8283624: Create an automated regression test for RFE-4390885
  • 53cb002: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • ... and 65 more: https://git.openjdk.org/jdk17u-dev/compare/bd7766321b2530d77835ca77e4b819cee6831a3f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2022
@openjdk openjdk bot closed this Aug 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@adinn @andrew-m-leonard Pushed as commit f74269c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants