Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302320: AsyncGetCallTrace obtains too few frames in sanity test #366

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Mar 6, 2023

Extended the AsyncGetCallTrace and fixed an issue with interpreter frames.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u pull/366/head:pull/366
$ git checkout pull/366

Update a local copy of the PR:
$ git checkout pull/366
$ git pull https://git.openjdk.org/jdk17u pull/366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 366

View PR using the GUI difftool:
$ git pr show -t 366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/366.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport db483a38a815f85bd9668749674b5f0f6e4b27b4 8302320: AsyncGetCallTrace obtains too few frames in sanity test Mar 6, 2023
@openjdk
Copy link

openjdk bot commented Mar 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302320: AsyncGetCallTrace obtains too few frames in sanity test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2023

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant