Skip to content
This repository has been archived by the owner. It is now read-only.

8278472: Invalid value set to CANDIDATEFORM structure #54

Closed
wants to merge 1 commit into from
Closed

8278472: Invalid value set to CANDIDATEFORM structure #54

wants to merge 1 commit into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Dec 21, 2021

According to the Windows API reference, dwStyle of CANDIDATEFORM structure should be set to CFS_CANDIDATEPOS or CFS_EXCLUDE. So, CFS_POINT is wrong here.

There are two instances in AwtComponent::SetCandidateWindow in awt_Component.cpp where the incorrect value is used.

I've created the PR for jdk18 as it's a low-risk fix. If it's inappropriate at this time, I'll open the PR for mainline jdk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278472: Invalid value set to CANDIDATEFORM structure

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/jdk18 pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/54.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2021

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 21, 2021
@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Dec 21, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2021

Webrevs

@aivanov-jdk
Copy link
Member Author

aivanov-jdk commented Jan 4, 2022

Any volunteers to review?

naotoj
naotoj approved these changes Jan 4, 2022
Copy link
Member

@naotoj naotoj left a comment

Looks correct.

@openjdk
Copy link

openjdk bot commented Jan 4, 2022

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278472: Invalid value set to CANDIDATEFORM structure

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 95a3010: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 58b5fb3: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • 06f3713: 8279379: GHA: Print tests that are in error
  • e7244c1: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • b4b0328: 8278824: Uneven work distribution when scanning heap roots in G1
  • 54b800d: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • 2945b78: 8279195: Document the -XX:+NeverActAsServerClassMachine flag
  • 6588bed: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail
  • 04ad668: 8279204: [BACKOUT] JDK-8278413: C2 crash when allocating array of size too large
  • 730f670: 8268297: jdk/jfr/api/consumer/streaming/TestLatestEvent.java times out
  • ... and 14 more: https://git.openjdk.java.net/jdk18/compare/467f654916764751746934f80877d49a5f107194...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 4, 2022
@prsadhuk
Copy link

prsadhuk commented Jan 6, 2022

It looks reasonable to me.. But for confidence, did you check if JDK-8147842, JDK-8184016 and JDK-8183504 still behaves properly.
Also, I guess since ATR is almost done, I think it will be more apt to place this PR on the mainline

@aivanov-jdk
Copy link
Member Author

aivanov-jdk commented Jan 19, 2022

Submitted a new PR for the mainline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client ready rfr
3 participants