Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk19 Public archive

8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 #154

Closed
wants to merge 4 commits into from

Conversation

alisenchung
Copy link

@alisenchung alisenchung commented Jul 23, 2022

open l10n msg drop
All tests passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jdk19 pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/154.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2022

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2022
@openjdk
Copy link

openjdk bot commented Jul 23, 2022

@alisenchung The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • i18n
  • javadoc
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jul 23, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2022

Webrevs

Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why MSG_Help_mac_launcher in src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties is left not localized? Is it intended to be localized in the next drop?

@alisenchung
Copy link
Author

Why MSG_Help_mac_launcher in src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties is left not localized? Is it intended to be localized in the next drop?

Probably will be left for next drop

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_en_US.properties: this should not be moved from java.base module
  • I still need some comments explaining XXX=XXX in the root bundle of CurrencyNames. Something like
These currency symbol entries are for the root bundle only to avoid throwing a MissingResourceException. Should not be copied into each localized resource bundle.

@@ -60,7 +60,6 @@
# or other dealings in these Data Files or Software without prior
# written authorization of the copyright holder.

CNY=\uffe5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove the original translation.

…back to base, readded original Chinese translation
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 1, 2022

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10

Reviewed-by: naoto, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
  • 4b3dfe1: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • 43bb399: 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022
  • e265b2a: 8290867: Race freeing remembered set segments
  • 54c093a: 8291524: jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java Value not equal to 2, field='hiddenClassCount', value='0'
  • 1d16c91: 8291512: Snippetize modules API examples
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455
  • 8c9d5ad: 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @alexeysemenyukoracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2022
@alexeysemenyukoracle
Copy link
Member

jpackage changes look good. Approved that part.

@alisenchung
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@alisenchung
Your change (at version 737b253) is now ready to be sponsored by a Committer.

@alexeysemenyukoracle
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 9, 2022

Going to push as commit 0def531.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
  • 4b3dfe1: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • 43bb399: 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022
  • e265b2a: 8290867: Race freeing remembered set segments
  • 54c093a: 8291524: jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java Value not equal to 2, field='hiddenClassCount', value='0'
  • 1d16c91: 8291512: Snippetize modules API examples
  • 36c00fd: 8291006: java/foreign/TestUnsupportedPlatform fails after JDK-8290455
  • 8c9d5ad: 8290455: jck test api/java_lang/foreign/VaList/Empty.html fails on some platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2022
@openjdk openjdk bot closed this Aug 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@alexeysemenyukoracle @alisenchung Pushed as commit 0def531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants