-
Notifications
You must be signed in to change notification settings - Fork 59
8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 #154
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
@alisenchung The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/java.base/share/classes/sun/util/resources/CurrencyNames_de.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why MSG_Help_mac_launcher
in src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_de.properties is left not localized? Is it intended to be localized in the next drop?
Probably will be left for next drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_en_US.properties: this should not be moved from
java.base
module - I still need some comments explaining
XXX=XXX
in the root bundle ofCurrencyNames
. Something like
These currency symbol entries are for the root bundle only to avoid throwing a MissingResourceException. Should not be copied into each localized resource bundle.
@@ -60,7 +60,6 @@ | |||
# or other dealings in these Data Files or Software without prior | |||
# written authorization of the copyright holder. | |||
|
|||
CNY=\uffe5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not remove the original translation.
…back to base, readded original Chinese translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @alexeysemenyukoracle) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
jpackage changes look good. Approved that part. |
/integrate |
@alisenchung |
/sponsor |
Going to push as commit 0def531.
Your commit was automatically rebased without conflicts. |
@alexeysemenyukoracle @alisenchung Pushed as commit 0def531. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
open l10n msg drop
All tests passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk19 pull/154/head:pull/154
$ git checkout pull/154
Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.org/jdk19 pull/154/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 154
View PR using the GUI difftool:
$ git pr show -t 154
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk19/pull/154.diff