Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8313250: Exclude java/foreign/TestByteBuffer.java on AIX #148

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 27, 2023

Hi all,

This pull request contains a backport of JDK-8313250, commit c05ba48b from the openjdk/jdk repository.

It's only a test exclusion for AIX, suitable for RDP2.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313250: Exclude java/foreign/TestByteBuffer.java on AIX (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/148/head:pull/148
$ git checkout pull/148

Update a local copy of the PR:
$ git checkout pull/148
$ git pull https://git.openjdk.org/jdk21.git pull/148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 148

View PR using the GUI difftool:
$ git pr show -t 148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/148.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c05ba48b60816db0165a6d3ff534fbbb18433cd4 8313250: Exclude java/foreign/TestByteBuffer.java on AIX Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@RealCLanger
Copy link
Contributor Author

/label nio

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@RealCLanger
The nio label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313250: Exclude java/foreign/TestByteBuffer.java on AIX

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit 1c875fd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@RealCLanger Pushed as commit 1c875fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants