8318082: ConcurrentModificationException from IndexWriter

[shipilev]

Unclean backport to fix a customer-visible bug in Javadoc tool. The uncleanliness comes from the missing refactoring (JDK-8309566, that looks unnecessary to backport.

Maybe @jonathan-gibbons and @pavelrappo want to take a look.

Additional testing:

• New test fails without the product fix, passes with it
• jdk/javadoc still passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318082 needs maintainer approval

Issue

• JDK-8318082: ConcurrentModificationException from IndexWriter (Bug - P4 - Approved)

Reviewers

• Pavel Rappo (@pavelrappo - Committer)
• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/23/head:pull/23
$ git checkout pull/23

Update a local copy of the PR:
$ git checkout pull/23
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/23/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23

View PR using the GUI difftool:
$ git pr show -t 23

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/23.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (d7f22a8a)
• 00: Full (fb40d3da)

[pavelrappo]

Output from git range-diff pull/23^! fc29a2e^! and this backport look fine.

[shipilev]

Still looking for formal (R)eviewers here, then I could apply for maintainer approval.

[shipilev]

@phohensee, @jerboaa, maybe?

[simonis]

Looks good.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Unclean backport to fix a customer-visible bug in Javadoc tool. There are contextual differences that prevent it from being clean. 21u PR acked by Jonathan, Pavel, and Volker.

[openjdk]

@shipilev
8318082: The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318082: ConcurrentModificationException from IndexWriter

Reviewed-by: prappo, simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• b745bb5: 8319883: Zero: Use atomic built-ins for 64-bit accesses
• a85f3f8: 8320145: Compiler should accept final variable in Record Pattern
• 1e66488: 8321599: Data loss in AVX3 Base64 decoding
• d4797b7: 8316693: Simplify at-requires checkDockerSupport()
• dfc9324: 8319879: Stress mode to randomize incremental inlining decision
• 307569f: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
• db1fa92: 8316594: C2 SuperWord: wrong result with hand unrolled loops
• c8caefa: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed
• e8aa37d: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
• 854c319: 8319569: Several java/util tests should be updated to accept VM flags
• ... and 10 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks all!

/integrate

[openjdk]

Going to push as commit 1a9c7ec.
Since your change was applied there have been 20 commits pushed to the master branch:

• b745bb5: 8319883: Zero: Use atomic built-ins for 64-bit accesses
• a85f3f8: 8320145: Compiler should accept final variable in Record Pattern
• 1e66488: 8321599: Data loss in AVX3 Base64 decoding
• d4797b7: 8316693: Simplify at-requires checkDockerSupport()
• dfc9324: 8319879: Stress mode to randomize incremental inlining decision
• 307569f: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
• db1fa92: 8316594: C2 SuperWord: wrong result with hand unrolled loops
• c8caefa: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed
• e8aa37d: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
• 854c319: 8319569: Several java/util tests should be updated to accept VM flags
• ... and 10 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 1a9c7ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.