Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac #415

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Mar 27, 2024

Clean backport to enable running JspawnhelperProtocol.java on MacOS.

GHA tested.
Additionally ran the test on macos.

Test report is stored in build/macosx-x86_64-server-fastdebug/test-results/jtreg_test_jdk_java_lang_ProcessBuilder_JspawnhelperProtocol_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java
                                                         1     1     0     0
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'macosx-x86_64-server-fastdebug'

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327998 needs maintainer approval

Issue

  • JDK-8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/415/head:pull/415
$ git checkout pull/415

Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 415

View PR using the GUI difftool:
$ git pr show -t 415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/415.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2024

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0bfb53c: 8323994: gtest runner repeats test name for every single gtest assertion
  • 7751996: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • e3f3647: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport cc1800fa4de3c1369efd46f5ca967ea82763f5d5 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2024

Webrevs

@elifaslan1
Copy link
Contributor Author

/approval request Clean backport to enable running JspawnhelperProtocol.java on MacOS. Risk is low, the change is test code only.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@elifaslan1
8327998: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 27, 2024
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@elifaslan1
Your change (at version d83ff68) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

Going to push as commit c263bc5.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 0bfb53c: 8323994: gtest runner repeats test name for every single gtest assertion
  • 7751996: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • e3f3647: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2024
@openjdk openjdk bot closed this Mar 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@phohensee @elifaslan1 Pushed as commit c263bc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants