-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac #415
Conversation
👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into |
@elifaslan1 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to enable running JspawnhelperProtocol.java on MacOS. Risk is low, the change is test code only. |
@elifaslan1 |
/integrate |
@elifaslan1 |
/sponsor |
Going to push as commit c263bc5.
Your commit was automatically rebased without conflicts. |
@phohensee @elifaslan1 Pushed as commit c263bc5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport to enable running JspawnhelperProtocol.java on MacOS.
GHA tested.
Additionally ran the test on macos.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/415/head:pull/415
$ git checkout pull/415
Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/415/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 415
View PR using the GUI difftool:
$ git pr show -t 415
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/415.diff
Webrev
Link to Webrev Comment