Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
/ jdk22 Public archive

8323675: Race in jdk.javadoc-gendata #96

Closed

Conversation

magicus
Copy link
Member

@magicus magicus commented Jan 23, 2024

This pull request contains a backport of commit 9049402a from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 19 Jan 2024 and was reviewed by Erik Joelsson and Jan Lahoda.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/96/head:pull/96
$ git checkout pull/96

Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.org/jdk22.git pull/96/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 96

View PR using the GUI difftool:
$ git pr show -t 96

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/96.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9049402a1b9394095b04287eef1f2d46c4da60e9 8323675: Race in jdk.javadoc-gendata Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

@shipilev
Copy link
Member

@magicus, did you mean jdk22u or jdk22? JDK 22 is in RDP2, which means P3 does not qualify.

@magicus
Copy link
Member Author

magicus commented Jan 29, 2024

@shipilev You are right. When I created https://bugs.openjdk.org/browse/JDK-8323675, JDK 22 were still in RDP1, and at that point it would have made sense to backport this. I made a mental note about this, but never got around to doing it until after RDP2, without realizing that it was not valid.

I will not propose backporting this to jdk22u; someone else will have to do that. I'll close this.

@magicus magicus closed this Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport build build-dev@openjdk.org clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants