Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head #4

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link

@yan-too yan-too commented May 16, 2022

I'd like to backport this leveling fix to 7u, too. All differences between patches for adapted for git 7u and e.g. 15u are in paths. First round of tests run OK (with testng 6.9).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk7u pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.java.net/jdk7u pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk7u/pull/4.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 16, 2022
@mlbridge
Copy link

mlbridge bot commented May 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 16, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 16, 2022
@yan-too
Copy link
Author

yan-too commented May 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2022

Going to push as commit 7ecb5b2.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2022
@openjdk openjdk bot closed this May 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2022
@openjdk
Copy link

openjdk bot commented May 16, 2022

@yan-too Pushed as commit 7ecb5b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the xml8285727 branch May 16, 2022 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
3 participants