-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3 #199
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@phohensee This backport pull request is now marked as clean |
@Rudometov This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Rudometov |
/sponsor |
Going to push as commit 77403ed.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit 77403ed. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for JDK-8286624 Regression Test CoordinateTruncationBug.java fails on OL8.3
Clean Backport, but the test needs to be moved due to 8 directory structure
New test, low risk.
Test passes during manual run on linux and mac.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/199/head:pull/199
$ git checkout pull/199
Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jdk8u-dev pull/199/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 199
View PR using the GUI difftool:
$ git pr show -t 199
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/199.diff