-
Notifications
You must be signed in to change notification settings - Fork 170
8276841: Add support for Visual Studio 2022 #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276841: Add support for Visual Studio 2022 #295
Conversation
👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Could you please run GHA on your fork? I don't see any CI results here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@AlexanderScherbatiy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
5261d02
to
729f690
Compare
@AlexanderScherbatiy Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Please ask for approval on the bug. |
/integrate |
Going to push as commit 644e79d.
Your commit was automatically rebased without conflicts. |
@AlexanderScherbatiy Pushed as commit 644e79d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of the fix from jdk11u-dev repository: openjdk/jdk11u-dev@0ba5a81
The fix is a parity fix for JDK-8298996 in 8u371 from Oracle.
The fix is manually merged with jdk8u-dev because it has conflicts in lines before the fix:
jdk11u-dev:
VALID_VS_VERSIONS="2017 2019 2013 2015 2012 2010"
jdk8u-dev:
VALID_VS_VERSIONS="2010 2012 2013 2015 2017 2019"
The conflict is resolved so
2022
year is placed after2019
in jdk8u-dev.The other part is backported as is into jdk8u-dev. The
generated-configure.sh
file is updated as well.To test the fix the jdk8u-dev was built on Windows Server 2012 R2 with:
and hotspot and compact3 tests were run. There were only 3 new failed tests comparing to the build without the fix.
The first test passes after the second run.
I rerun the tests with build without the fix and these 3 tests failed as well.
It looks like that these failures actually are not related to the fix.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/295/head:pull/295
$ git checkout pull/295
Update a local copy of the PR:
$ git checkout pull/295
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/295/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 295
View PR using the GUI difftool:
$ git pr show -t 295
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/295.diff
Webrev
Link to Webrev Comment