Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321480: ISO 4217 Amendment 176 Update #561

Closed
wants to merge 4 commits into from

Conversation

Karm
Copy link
Contributor

@Karm Karm commented Aug 14, 2024

backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update

depends on #559


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321480 needs maintainer approval

Issue

  • JDK-8321480: ISO 4217 Amendment 176 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561
$ git checkout pull/561

Update a local copy of the PR:
$ git checkout pull/561
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 561

View PR using the GUI difftool:
$ git pr show -t 561

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/561.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2024

👋 Welcome back Karm! A progress list of the required criteria for merging this PR into pr/559 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@Karm This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321480: ISO 4217 Amendment 176 Update

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • edbdf05: 8336928: GHA: Bundle artifacts removal broken

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ea06b5c966e9261cacb35300ddde6eae48ec632f 8321480: ISO 4217 Amendment 176 Update Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 14, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2024

Webrevs

@Karm Karm mentioned this pull request Aug 14, 2024
4 tasks
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/559 to master August 19, 2024 08:34
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout pr-559-amendment-175-176
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@Karm
Copy link
Contributor Author

Karm commented Aug 19, 2024

/approval request Backporting regular ISO 4217 update from JDK 11. It's currency data update plus bringing along a workaround for missing JDK-8310923 (no JUnit refactoring). Passes tests in jdk/test/java/util/Currency/.

@openjdk
Copy link

openjdk bot commented Aug 19, 2024

@Karm
8321480: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 19, 2024
@Karm
Copy link
Contributor Author

Karm commented Aug 19, 2024

Faild test:

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca
...
Caused by: java.io.IOException: Server returned HTTP response code: 502 for URL: http://ocsps.ssl.com/
...

IMHO OCSP responder is just down...

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What testing have you done?

Comment on lines 26 to 27
* 8074350 8074351 8145952 8187946 8193552 8202026 8204269
* 8208746 8209775 8274658 8283277 8296239
* 8039317 8074350 8074351 8145952 8187946 8193552 8202026 8204269
* 8208746 8209775 8264792 8274658 8283277 8296239 8321480
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be a one-line change appending 8321480 to the last line. See the JDK 11u commit which does the same thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Karm
Copy link
Contributor Author

Karm commented Aug 20, 2024

@jerboaa

What testing have you done?

karm@laptop:~/Tools/jtreg/build/images/jtreg/bin ((jtreg-7.4+1))$
TIME=`date +%s`;mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; jtreg -a -ignore:quiet 
-w:test.${TIME}/jdk/JTwork -r:test.${TIME}/jdk/JTreport -jdk:/home/karm/workspaceRH/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/ 
/home/karm/workspaceRH/jdk8u/jdk/test/java/util/Currency/

Test results: passed: 5
Report written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724152749/jdk/JTreport/html/report.html
Results written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724152749/jdk/JTwork

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@Karm
Copy link
Contributor Author

Karm commented Aug 20, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@Karm
Your change (at version bc18ee3) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 20, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

Going to push as commit 439e910.
Since your change was applied there has been 1 commit pushed to the master branch:

  • edbdf05: 8336928: GHA: Bundle artifacts removal broken

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 20, 2024
@openjdk openjdk bot closed this Aug 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@jerboaa @Karm Pushed as commit 439e910.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants