-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321480: ISO 4217 Amendment 176 Update #561
Conversation
👋 Welcome back Karm! A progress list of the required criteria for merging this PR into |
@Karm This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout pr-559-amendment-175-176
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
…9-amendment-175-176
/approval request Backporting regular ISO 4217 update from JDK 11. It's currency data update plus bringing along a workaround for missing JDK-8310923 (no JUnit refactoring). Passes tests in jdk/test/java/util/Currency/. |
Faild test:
IMHO OCSP responder is just down... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What testing have you done?
* 8074350 8074351 8145952 8187946 8193552 8202026 8204269 | ||
* 8208746 8209775 8274658 8283277 8296239 | ||
* 8039317 8074350 8074351 8145952 8187946 8193552 8202026 8204269 | ||
* 8208746 8209775 8264792 8274658 8283277 8296239 8321480 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should only be a one-line change appending 8321480
to the last line. See the JDK 11u commit which does the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/integrate |
/sponsor |
backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update
depends on #559
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561
$ git checkout pull/561
Update a local copy of the PR:
$ git checkout pull/561
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/561/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 561
View PR using the GUI difftool:
$ git pr show -t 561
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/561.diff
Webrev
Link to Webrev Comment