Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239109: Update SQLite to version 3.31.1 #119

Closed
wants to merge 1 commit into from
Closed

Conversation

@guruhb
Copy link
Contributor

guruhb commented Feb 20, 2020

Updating SQLite to version 3.31.1 (Currently used version is 3.30.1).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Arun Joseph (ajoseph - Author)
  • Kevin Rushforth (kcr - Reviewer)
  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/119/head:pull/119
$ git checkout pull/119

@guruhb guruhb requested review from johanvos and kevinrushforth Feb 20, 2020
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2020

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 20, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2020

Webrevs

@kevinrushforth
Copy link
Member

kevinrushforth commented Feb 20, 2020

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 20, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk
Copy link

openjdk bot commented Feb 20, 2020

@guruhb This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8239109: Update SQLite to version 3.31.1

Reviewed-by: ajoseph, kcr, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d8e7f850f6c046f827d0a89c5404e41edf705d7e.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 20, 2020
@guruhb
Copy link
Contributor Author

guruhb commented Feb 24, 2020

/integrate

@openjdk openjdk bot closed this Feb 24, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 24, 2020
@openjdk
Copy link

openjdk bot commented Feb 24, 2020

@guruhb The following commits have been pushed to master since your change was applied:

  • d8e7f85: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions

Your commit was automatically rebased without conflicts.

Pushed as commit 4eaff0d.

@openjdk openjdk bot removed the rfr label Feb 24, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2020

Mailing list message from Guru Hb on openjfx-dev:

Changeset: 4eaff0d
Author: Guru Hb <ghb at openjdk.org>
Date: 2020-02-24 04:08:43 +0000
URL: https://git.openjdk.java.net/jfx/commit/4eaff0de

8239109: Update SQLite to version 3.31.1

Reviewed-by: ajoseph, kcr, jvos

! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/VERSION
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3.c
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3.h
! modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/sqlite3ext.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.