Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231735: gradle checkrepo is obsolete and doesn't work with git #2

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 2, 2019

https://bugs.openjdk.java.net/browse/JDK-8231735

This removes the obsolete checkrepo and checkrepoall gradle tasks. They use a script which assumes Mercurial support, and so no longer run. Also, with git jcheck support now available, these tasks are no longer needed.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Approvers

@kevinrushforth kevinrushforth self-assigned this Oct 2, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Oct 2, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2019

Webrevs

@openjdk openjdk bot removed the rfr Ready for review label Oct 3, 2019
@openjdk
Copy link

openjdk bot commented Oct 3, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

8231735: gradle checkrepo is obsolete and doesn't work with git

Reviewed-by: aghaisas
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 3, 2019
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 3, 2019
@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2019
@openjdk
Copy link

openjdk bot commented Oct 3, 2019

@kevinrushforth Pushed as commit f595cc1.

@openjdk openjdk bot removed the ready Ready to be integrated label Oct 3, 2019
@kevinrushforth kevinrushforth deleted the 8231735-rm-checkrepo branch October 3, 2019 17:03
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: f595cc1
Author: Kevin Rushforth
Date: 2019-10-03 16:58:02 +0000
URL: https://git.openjdk.java.net/jfx/commit/f595cc19

8231735: gradle checkrepo is obsolete and doesn't work with git

Reviewed-by: aghaisas

! build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants