Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231590: Update location of jfx repo to GitHub in third-party legal files #3

Closed

Conversation

@kevinrushforth
Copy link
Member

kevinrushforth commented Oct 2, 2019

https://bugs.openjdk.java.net/browse/JDK-8231590

Replaces http://hg.openjdk.java.net/openjfx/jfx/rt with https://github.com/openjdk/jfx in three third-party legal files. After this change, there are no more references to hg.openjdk.java.net in the repo.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Approvers

  • Alexander Matveev (almatvee - Reviewer)
@kevinrushforth kevinrushforth self-assigned this Oct 2, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@kevinrushforth
Copy link
Member Author

kevinrushforth commented Oct 2, 2019

@sashamatveev can you review this?

@openjdk openjdk bot added the rfr label Oct 2, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2019

Webrevs

Copy link

sashamatveev left a comment

Looks good.

@openjdk openjdk bot removed the rfr label Oct 3, 2019
@openjdk
Copy link

openjdk bot commented Oct 3, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

8231590: Update location of jfx repo to GitHub in third-party legal files

Reviewed-by: almatvee
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • f595cc1: 8231735: gradle checkrepo is obsolete and doesn't work with git

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 3, 2019
@kevinrushforth
Copy link
Member Author

kevinrushforth commented Oct 3, 2019

/integrate

@openjdk openjdk bot closed this Oct 3, 2019
@openjdk openjdk bot added the integrated label Oct 3, 2019
@openjdk
Copy link

openjdk bot commented Oct 3, 2019

@kevinrushforth The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 0a0d34a.

@openjdk openjdk bot removed the ready label Oct 3, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 0a0d34a
Author: Kevin Rushforth
Date: 2019-10-03 21:48:44 +0000
URL: https://git.openjdk.java.net/jfx/commit/0a0d34a0

8231590: Update location of jfx repo to GitHub in third-party legal files

Reviewed-by: almatvee

! modules/javafx.media/src/main/legal/glib.md
! modules/javafx.media/src/main/legal/gstreamer.md
! modules/javafx.web/src/main/legal/webkit.md

@kevinrushforth kevinrushforth deleted the kevinrushforth:8231590-tprm-github branch Oct 5, 2019
johanvos added a commit to johanvos/jfx that referenced this pull request Feb 22, 2020
Androidkeyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.