Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8237469: Inherited styles don't update when node is moved #87
Everything passes with the fix and 5 of the new tests fail without the fix.
I doubt this will cause a significant performance decrease. I think it's worth it for correctness. The only other thing is that I kept the fix to the minimum, but technically canReuseHelper now has a side effect. I could try rewrite some things if necessary, or maybe rename the method? Else leave it as is?
JDK-8237469: Inherited styles don't update when node is moved
I ran it and it seems to work. The button is always red in the red pane and always yellow in the yellow one.
@DeanWookey This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 23 commits pushed to the
As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dsgrieve, @aghaisas, @kevinrushforth) but any other Committer may sponsor as well.
Your commit was automatically rebased without conflicts.
Pushed as commit 6968e38.
8237469: Inherited styles don't update when node is moved
Reviewed-by: dgrieve, aghaisas, kcr