8256275: Optimized build is broken

Reviewed-by: redestad, coleenp

Author: Vladimir Ivanov

src/hotspot/share/classfile/vmIntrinsics.cpp

@@ -705,7 +705,7 @@ const char* vmIntrinsics::short_name_as_C_string(vmIntrinsics::ID id, char* buf,
 
 #define ID4(x, y, z, f) ((ID3(x, y, z) << vmIntrinsics::log2_FLAG_LIMIT) | (jlong) (f))
 
-#ifdef ASSERT
+#ifndef PRODUCT
 static const jlong intrinsic_info_array[vmIntrinsics::ID_LIMIT+1] = {
 #define VM_INTRINSIC_INFO(ignore_id, klass, name, sig, fcode) \
   ID4(SID_ENUM(klass), SID_ENUM(name), SID_ENUM(sig), vmIntrinsics::fcode),
@@ -747,4 +747,4 @@ vmIntrinsics::Flags vmIntrinsics::flags_for(vmIntrinsics::ID id) {
   assert(((ID4(1021,1022,1023,15) >> shift) & mask) == 15, "");
   return Flags( (info >> shift) & mask );
 }
-#endif // ASSERT
+#endif // !PRODUCT

src/hotspot/share/classfile/vmIntrinsics.hpp

@@ -1092,7 +1092,7 @@ class vmIntrinsics : AllStatic {
     return id;
   }
 
-#ifdef ASSERT
+#ifndef PRODUCT
   // Find out the symbols behind an intrinsic:
   static vmSymbolID     class_for(ID id);
   static vmSymbolID      name_for(ID id);

src/hotspot/share/gc/g1/g1RemSet.hpp

@@ -68,7 +68,7 @@ class G1RemSet: public CHeapObj<mtGC> {
 
   void print_merge_heap_roots_stats();
 
-  void assert_scan_top_is_null(uint hrm_index) PRODUCT_RETURN;
+  void assert_scan_top_is_null(uint hrm_index) NOT_DEBUG_RETURN;
 public:
 
   typedef CardTable::CardValue CardValue;

src/hotspot/share/runtime/stackWatermark.hpp

@@ -101,7 +101,7 @@ class StackWatermark : public CHeapObj<mtInternal> {
   void yield_processing();
   static bool has_barrier(const frame& f);
   void ensure_safe(const frame& f);
-  void assert_is_frame_safe(const frame& f) PRODUCT_RETURN;
+  void assert_is_frame_safe(const frame& f) NOT_DEBUG_RETURN;
   bool is_frame_safe(const frame& f);
 
   // API for consumers of the stack watermark barrier.