Skip to content

Commit c7a2c24

Browse files
robcaslozTobiHartmann
authored andcommitted
8255797: ciReplay: improve documentation of replay file syntax in parser
Complete and disambiguate the informal specification of the replay file syntax given in the ciReplay class implementation. Reviewed-by: kvn, thartmann
1 parent a5d8a9c commit c7a2c24

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/hotspot/share/ci/ciReplay.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ class CompileReplay : public StackObj {
494494
return true;
495495
}
496496

497-
// compile <klass> <name> <signature> <entry_bci> <comp_level> inline <count> <depth> <bci> <klass> <name> <signature> ...
497+
// compile <klass> <name> <signature> <entry_bci> <comp_level> inline <count> (<depth> <bci> <klass> <name> <signature>)*
498498
void* process_inline(ciMethod* imethod, Method* m, int entry_bci, int comp_level, TRAPS) {
499499
_imethod = m;
500500
_iklass = imethod->holder();
@@ -524,7 +524,7 @@ class CompileReplay : public StackObj {
524524
return NULL;
525525
}
526526

527-
// compile <klass> <name> <signature> <entry_bci> <comp_level> inline <count> <depth> <bci> <klass> <name> <signature> ...
527+
// compile <klass> <name> <signature> <entry_bci> <comp_level> inline <count> (<depth> <bci> <klass> <name> <signature>)*
528528
void process_compile(TRAPS) {
529529
Method* method = parse_method(CHECK);
530530
if (had_error()) return;
@@ -606,8 +606,6 @@ class CompileReplay : public StackObj {
606606
}
607607

608608
// ciMethod <klass> <name> <signature> <invocation_counter> <backedge_counter> <interpreter_invocation_count> <interpreter_throwout_count> <instructions_size>
609-
//
610-
//
611609
void process_ciMethod(TRAPS) {
612610
Method* method = parse_method(CHECK);
613611
if (had_error()) return;
@@ -619,7 +617,7 @@ class CompileReplay : public StackObj {
619617
rec->_instructions_size = parse_int("instructions_size");
620618
}
621619

622-
// ciMethodData <klass> <name> <signature> <state> <current mileage> orig <length> # # ... data <length> # # ... oops <length> # ... methods <length>
620+
// ciMethodData <klass> <name> <signature> <state> <current_mileage> orig <length> <byte>* data <length> <ptr>* oops <length> (<offset> <klass>)* methods <length> (<offset> <klass> <name> <signature>)*
623621
void process_ciMethodData(TRAPS) {
624622
Method* method = parse_method(CHECK);
625623
if (had_error()) return;
@@ -694,7 +692,7 @@ class CompileReplay : public StackObj {
694692
Klass* k = parse_klass(CHECK);
695693
}
696694

697-
// ciInstanceKlass <name> <is_linked> <is_initialized> <length> tag # # # ...
695+
// ciInstanceKlass <name> <is_linked> <is_initialized> <length> tag*
698696
//
699697
// Load the klass 'name' and link or initialize it. Verify that the
700698
// constant pool is the same length as 'length' and make sure the
@@ -789,10 +787,12 @@ class CompileReplay : public StackObj {
789787
}
790788
}
791789

790+
// staticfield <klass> <name> <signature> <value>
791+
//
792792
// Initialize a class and fill in the value for a static field.
793793
// This is useful when the compile was dependent on the value of
794794
// static fields but it's impossible to properly rerun the static
795-
// initiailizer.
795+
// initializer.
796796
void process_staticfield(TRAPS) {
797797
InstanceKlass* k = (InstanceKlass *)parse_klass(CHECK);
798798

@@ -906,6 +906,7 @@ class CompileReplay : public StackObj {
906906
}
907907

908908
#if INCLUDE_JVMTI
909+
// JvmtiExport <field> <value>
909910
void process_JvmtiExport(TRAPS) {
910911
const char* field = parse_string();
911912
bool value = parse_int("JvmtiExport flag") != 0;

0 commit comments

Comments
 (0)