Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271536: [lworld] VerifyError in hotspot/jtreg/runtime/classFileParserBug/NameAndTypeSig.java #514

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Jul 30, 2021

Please review this fix for JDK-8271536. The fix throws a ClassFormatError exception for methods named if they have a non-void function return type that is a basic primitive type, such as D or I regardless of the setting of EnableValhalla.. Note that additional changes may be needed in the future depending on how method and possibly are defined in future JVM Specs.

The fix was tested by running the JCK lang and VM tests and Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8271536: [lworld] VerifyError in hotspot/jtreg/runtime/classFileParserBug/NameAndTypeSig.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/514/head:pull/514
$ git checkout pull/514

Update a local copy of the PR:
$ git checkout pull/514
$ git pull https://git.openjdk.java.net/valhalla pull/514/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 514

View PR using the GUI difftool:
$ git pr show -t 514

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/514.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 30, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271536: [lworld] VerifyError in hotspot/jtreg/runtime/classFileParserBug/NameAndTypeSig.java

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 30, 2021

Webrevs

@hseigel
Copy link
Member Author

@hseigel hseigel commented Jul 30, 2021

Thanks Fred for the review and off-line discussion!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

Going to push as commit ecca7a0.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 30, 2021

@hseigel Pushed as commit ecca7a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants