Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating pull request for 10.21105.joss.05789 #4728

Closed
wants to merge 3 commits into from
Closed

Conversation

editorialbot
Copy link
Collaborator

If this looks good then :shipit:

@matthewfeickert
Copy link
Member

@kyleniemeyer from the @editorialbot commands is there one to rerender the entire paper process (now that jet-net/JetNet#61 is merged)? Or do we just only rerender the PDF with @editorialbot generate pdf?

@editorialbot editorialbot deleted the joss.05789 branch October 30, 2023 14:00
@kyleniemeyer
Copy link

@matthewfeickert we just check the PDF as usual using generate pdf and then I will accept if it looks good. Nothing special really happens with the recommend accept, it's just a dry run.

@matthewfeickert
Copy link
Member

Ah okay thanks. I had misunderstood it as a dry run that then becomes a staging ground, but it makes sense to have only a single point of truth for generating the final paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants