[PRE REVIEW]: Hankel Transformation for Noisy Data - The Multiple Scattering Problem #1375
Comments
|
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type: What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
|
PDF failed to compile for issue #1375 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
|
Failed to discover a valid open source license. |
|
@whedon generate pdf |
|
|
PDF failed to compile for issue #1375 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
|
@arfon : I have no clue why this paper is not compiling. Help! |
|
@katyhuff 👋 — the submitting author suggested you as handling editor. Looks like there's some physics in here! I'll assign you now, but let me know if you're disinclined for any reason. |
|
OK, the editor is @katyhuff |
|
There's an unmatched quotation on the title line of the paper. Line #2 of I would @-mention the author but they appear to have used an invalid GitHub handle when submitting the paper (I've emailed them directly about this). |
|
Dear Kathryn, does the PDF compile now? It should work now. Or does the make command not work. In any case please send error list - then I know better.... |
|
@whedon generate pdf |
|
|
PDF failed to compile for issue #1375 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in |
|
Dear all,
this looks ok for me now.
Best,
Henrich
Am 29.04.2019 um 15:23 schrieb whedon <notifications@github.com<mailto:notifications@github.com>>:
PDF failed to compile for issue #1375<#1375> with the following error:
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1375/paper.md): found character that cannot start any token while scanning for the next token at line 7 column 11 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:68:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
'
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1375 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AL6I7KVTOK2X4HSQAJMIC7TPS3ZEHANCNFSM4HF2P5ZQ>.
…------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender),
Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
|
|
Looks ok for me now |
|
@whedon generate pdf |
|
|
Thank you @hfriel69 - it is indeed building a pdf now! A few comments, before we start assigning reviewers.
While making these changes, please double check that your paper mentions (if applicable) of any ongoing research projects using the software or recent scholarly publications enabled by it. I assume that this work was created for a specific task at JCNS. Perhaps this could be mentioned? |
|
My suggestions for Referees: |
|
Intro added for non specialists |
|
Dear Kathy,
I added an intro for non-specialists.
Best,
Henrich
Am 29.04.2019 um 17:04 schrieb Katy Huff <notifications@github.com<mailto:notifications@github.com>>:
@hfriel69<https://github.com/hfriel69> Thank you for these suggestions. As soon as you are able to make the preliminary changes I suggested above<#1375 (comment)>, I will assign reviewers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1375 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AL6I7KXB53FFPD4KNVU47RLPS4E7DANCNFSM4HF2P5ZQ>.
…------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender),
Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
|
|
@whedon generate pdf |
|
|
@hfriel69 : I think you may have misunderstood my comment about the name field. The "name" parameter in the paper.md file typically contains the author's actual name, rather than their username. (in your case, "Henrich Frielinghaus" is the appropriate entry.) Would you mind please editing the paper to use your name? |
|
Name is correct now. Other smaller changes added. Sorry: I'm completely new to the github world, and especially the convention of md files is a little confusing. |
|
@katyhuff: Is there everything fine with the manuscript and the program? I assume you are searching for referees... |
|
two more referee could be: |
|
Thanks for these suggestions. Indeed, I'm identifying referees from our pool and am investigating your suggestions. I'll be able to give this some more attention this weekend. |
|
Dear Katy, do I need to bring more reviewers? Do you need anything else? Best, Henrich |
|
@whedon generate pdf |
|
|
@hfriel69 Thank you for your patience. Before finalizing reviewer assignments, I typically conduct a cursory check that the basic review criteria have a chance of passing the process. In the case of your MuScatt repository, I notice a number of key review criteria that are missing. I cannot move forward with assigning reviewers without such elements, and I recommend that you withdraw your submission in order to take some time to incorporate those elements so that a future resubmission will be successful. Finally, I noticed there is a file, fftsg.c which appears to have been copied verbatim from elswhere (perhaps http://www.kurims.kyoto-u.ac.jp/~ooura/fft.html). Their license requests attribution, which is missing in your repository. For reference, the review criteria can be found in the JOSS author guidelines. The missing elements include: Installation instructionsI predict From the review criteria page:
Contributor instructionsI do not see any contributor guidelines in MuScatt.
TestsI see no tests in the MuScatt repository. Though I see a handful of scattered .dat files, I cannot immediately tell their purpose, and I assume they are supportive rather than validating.
API DocumentationThough I see that MuScatt.c has a few scattered comments, there is no API to speak of. Instead, all logic is embedded in a single procedural block of code (in the main() function.). The exception is the fftsg.c file, which, as mentioned above, seems to have been copied from elsewhere without attribution.
|
|
It's been more than four months since we last heard from the submitting author. I'm therefore going to assume they are no longer interested in pursuing this publication and withdraw the submission on their behalf. @hfriel69 - we'd welcome a re-submission in the future if you're able to address @katyhuff's feedback here. |
Submitting author: @hfriel69 (Henrich Frielinghaus)
Repository: https://jugit.fz-juelich.de/sans/muscatt
Version: v1.0.0
Editor: @katyhuff
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @h.frielinghaus. Currently, there isn't an JOSS editor assigned to your paper.
@h.frielinghaus if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: