Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: greeks: Sensitivities of Prices of Financial Options and Implied Volatilities #5768

Closed
editorialbot opened this issue Aug 18, 2023 · 41 comments
Closed

[PRE REVIEW]: greeks: Sensitivities of Prices of Financial Options and Implied Volatilities #5768

editorialbot opened this issue Aug 18, 2023 · 41 comments
Assignees
@csoneson @lrnv @bahung
Labels
C++ pre-review R TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 18, 2023 •
edited

Submitting author: @ahudde (Anselm Hudde)
Repository: https://github.com/ahudde/greeks
Branch with paper.md (empty if default branch):
Version: 1.2.0
Editor: @csoneson
Reviewers: @lrnv, @bahung
Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/61ae139acab91fdb0664b33a23e43c93"><img src="https://joss.theoj.org/papers/61ae139acab91fdb0664b33a23e43c93/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/61ae139acab91fdb0664b33a23e43c93/status.svg)](https://joss.theoj.org/papers/61ae139acab91fdb0664b33a23e43c93)

Author instructions

Thanks for submitting your paper to JOSS @ahudde. Currently, there isn't a JOSS editor assigned to your paper.

@ahudde if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Aug 18, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (1085.0 files/s, 122353.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               16            412            400           1942
C++                             13             57            345            347
Markdown                         3             69              0            197
TeX                              1              8              0             51
YAML                             1              1              4             18
Rmd                              1             21             71              4
-------------------------------------------------------------------------------
SUM:                            35            568            820           2559
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s11009-023-10014-5 is OK

MISSING DOIs

- 10.1007/978-1-4419-9230-7_2 may be a valid DOI for title: Options, futures, and other derivatives

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 483

@oliviaguest
Copy link
Member

@sbenthall if you have capacity, this might be up your street? 😊

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@oliviaguest
Copy link
Member

@sbenthall ?

@arfon
Copy link
Member

arfon commented Sep 27, 2023

@editorialbot invite @sbenthall as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@arfon
Copy link
Member

arfon commented Sep 27, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

GlobalSensitivity.jl: Performant and Parallel Global Sensitivity Analysis with Julia
Submitting author: @Vaibhavdixit02
Handling editor: @jbytecode (Active)
Reviewers: @zhenwu0728, @storyetfall
Similarity score: 0.8056

RiskPortfolios: Computation of Risk-Based Portfolios in R
Submitting author: @ArdiaD
Handling editor: @arfon (Active)
Reviewers: @braverock
Similarity score: 0.8013

Visualizations with statistical details: The ggstatsplot approach
Submitting author: @IndrajeetPatil
Handling editor: @csoneson (Active)
Reviewers: @njtierney, @kevinrue
Similarity score: 0.7982

Gravity: Estimation Methods for Gravity Models in R
Submitting author: @pachamaltese
Handling editor: @yochannah (Retired)
Reviewers: @DiegoKoz
Similarity score: 0.7962

effectsize: Estimation of Effect Size Indices and Standardized Parameters
Submitting author: @mattansb
Handling editor: @mikldk (Retired)
Reviewers: @trashbirdecology, @jkarreth
Similarity score: 0.7961

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@sbenthall
Copy link

sbenthall commented Sep 27, 2023 via email

@oliviaguest
Copy link
Member

@jbytecode @csoneson do you have capacity for this? 😊

@jbytecode
Copy link

@oliviaguest - I prefer to wait to hear from @csoneson as I am not really available. In the worst-case scenario, I can take care of this.

@csoneson
Copy link
Member

Sure, I can give it a go 🙂

@csoneson
Copy link
Member

@editorialbot assign @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @csoneson is now the editor

@csoneson
Copy link
Member

👋🏻 @ahudde - I will handle your submission and start by finding at least two suitable reviewers. If you have suggestions (e.g. based on the list mentioned in the first post, please feel free to mention them here.

@ahudde
Copy link

ahudde commented Oct 11, 2023

Dear @csoneson,

Thank you very much for being editor for my submission. I do not have suggestions, but I could suggest some reviewers if this helps your work.

@csoneson
Copy link
Member

👋🏻 @rmcd1024, @ArdiaD, @syoh - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
(#5768)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@ArdiaD
Copy link

ArdiaD commented Oct 13, 2023

Sorry @csoneson ; already declined another review last week becaure under water here.

@csoneson
Copy link
Member

@ArdiaD - no worries, thanks for the quick response!

@rmcd1024
Copy link

rmcd1024 commented Oct 16, 2023 via email

@csoneson
Copy link
Member

@rmcd1024 We usually ask reviewers to provide an initial assessment within 2-3 weeks. In many cases it may be easier to raise points and provide comments in the associated GitHub issue as one goes through the submission, rather than posting all comments in one go. The checklist contains the aspects that we ask reviewers to check for in the submission - some of the points can be quickly checked, but others of course involve installing and testing the software.

@syoh
Copy link

syoh commented Oct 17, 2023

@csoneson, thanks for the invitation. I have been wanting to do a review for JOSS. Unfortunately, my hands are full until next April, but I am happy to review something then.

@csoneson
Copy link
Member

@rmcd1024 - given the additional information below, would you be available to review this submission for JOSS?

@rmcd1024 We usually ask reviewers to provide an initial assessment within 2-3 weeks. In many cases it may be easier to raise points and provide comments in the associated GitHub issue as one goes through the submission, rather than posting all comments in one go. The checklist contains the aspects that we ask reviewers to check for in the submission - some of the points can be quickly checked, but others of course involve installing and testing the software.

@csoneson
Copy link
Member

👋🏻 @borab96, @lrnv - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
(#5768)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@lrnv
Copy link

lrnv commented Oct 19, 2023

@csoneson Yep i'll take it :)

@csoneson
Copy link
Member

@lrnv Awesome, thanks :) As soon as we have secured one more reviewer I'll open the review issue.

@csoneson
Copy link
Member

@editorialbot add @lrnv as reviewer

@editorialbot
Copy link
Collaborator Author

@lrnv added to the reviewers list!

@rmcd1024
Copy link

rmcd1024 commented Oct 19, 2023 via email

@csoneson
Copy link
Member

@rmcd1024 no worries, thanks for your reply!

@csoneson
Copy link
Member

👋🏻 @bahung, @edrictam - would one of you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

greeks: Sensitivities of Prices of Financial Options and Implied Volatilities
(#5768)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@bahung
Copy link

bahung commented Oct 25, 2023 via email

@csoneson
Copy link
Member

@bahung Thank you! I will assign you and start the review issue

@csoneson
Copy link
Member

@editorialbot add @bahung as reviewer

@editorialbot
Copy link
Collaborator Author

@bahung added to the reviewers list!

@csoneson
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csoneson csoneson

@lrnv lrnv

@bahung bahung

Labels
C++ pre-review R TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests