doc: add missing notes #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: openjs-foundation#353 Closes: openjs-foundation#381 Closes: openjs-foundation#395 Closes: openjs-foundation#401 Closes: openjs-foundation#408 Closes: openjs-foundation#412 Closes: openjs-foundation#416
joesepi
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
LGTM. Thanks @MylesBorins -- I've been meaning to do this. :(
christian-bromann
approved these changes
Dec 14, 2019
ljharb
approved these changes
Dec 14, 2019
eemeli
approved these changes
Dec 14, 2019
codeekage
approved these changes
Dec 15, 2019
dmethvin
approved these changes
Dec 15, 2019
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #353
Closes: #381
Closes: #395
Closes: #401
Closes: #408
Closes: #412
Closes: #416