Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade minimum dockerapi version #1510

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented Feb 24, 2024

Ⅰ. Describe what this PR does

Fix #1508

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Feb 24, 2024
@hantmac hantmac force-pushed the fix/upgrade-dockerapi-version branch from 61909fb to d7e1817 Compare February 24, 2024 16:17
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.23%. Comparing base (5421ee7) to head (245221c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
+ Coverage   48.55%   49.23%   +0.67%     
==========================================
  Files         157      157              
  Lines       22480    22604     +124     
==========================================
+ Hits        10916    11128     +212     
+ Misses      10360    10262      -98     
- Partials     1204     1214      +10     
Flag Coverage Δ
unittests 49.23% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Feb 28, 2024

@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/XS size/XS: 0-9 labels Feb 28, 2024
Signed-off-by: hantmac <hantmac@outlook.com>
Signed-off-by: hantmac <hantmac@outlook.com>
@hantmac hantmac force-pushed the fix/upgrade-dockerapi-version branch from 24158c7 to 245221c Compare February 28, 2024 02:35
@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 6bb78c4 into openkruise:master Mar 1, 2024
27 checks passed
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
* fix: upgrade minimum dockerapi version


* fix codecov


---------
@wingyiu
Copy link

wingyiu commented Jul 8, 2024

release the bugfix please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] K8s1.21 安装kruise 提示docker客户端版本过低
5 participants