-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement StatefulSetStartOrdinal #1643
Conversation
113f941
to
87349c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1643 +/- ##
==========================================
+ Coverage 47.91% 49.21% +1.30%
==========================================
Files 162 183 +21
Lines 23491 18951 -4540
==========================================
- Hits 11256 9327 -1929
+ Misses 11014 8404 -2610
+ Partials 1221 1220 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
87349c2
to
e4d49f1
Compare
2387ca6
to
37a905b
Compare
5218318
to
f8bffff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment in L370 also need modification
// slice that will contain all Pods such that 0 <= getOrdinal(pod) < replicaCount and not in reserveOrdinals
79b1a43
to
19d6673
Compare
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
19d6673
to
b7e0ff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
implement StatefulSetStartOrdinal
Ⅱ. Does this pull request fix one issue?
fixes #1642
Ⅲ. Describe how to verify it
implement StatefulSetStartOrdinal
Ⅳ. Special notes for reviews