-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pod index label for Advanced StatefulSet #1667
Conversation
Welcome @cr7258! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 47.91% 48.84% +0.92%
==========================================
Files 162 188 +26
Lines 23491 19273 -4218
==========================================
- Hits 11256 9414 -1842
+ Misses 11014 8630 -2384
- Partials 1221 1229 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cr7258 plz rebase the master and resolve the conflicts |
@furykerry resolved the conflict, please review it again, thanks. |
plz resolve the conflicts by rebasing the master, and plz squash the commits into one |
Signed-off-by: Se7en <chengzw258@163.com>
/lgtm |
/lgtm |
@ABNER-1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add Pod Index Label for Advanced StatefulSet.
Ⅱ. Does this pull request fix one issue?
fixes #1660
Ⅲ. Describe how to verify it
Deploy an Advanced StatefulSet resource.
The Pod is added an
apps.kubernetes.io/pod-index
label.Ⅳ. Special notes for reviews