fix: Replace calls to timeAgo with formatDateAsTimeAgo #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaskienle
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new utility function formatDateAsTimeAgo to replace direct usage of the timeAgo instance, providing better error handling for invalid or missing date strings. The function gracefully handles edge cases by returning an empty string for invalid dates instead of throwing errors.
- Added
formatDateAsTimeAgofunction with input validation and error handling - Updated all existing usages of
timeAgo.format(new Date(...))to use the new function - Added comprehensive test coverage for the new utility function
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/i18n/timeAgo.ts | Adds new formatDateAsTimeAgo function and makes timeAgo instance private |
| src/utils/i18n/timeAgo.spec.ts | Comprehensive test suite for the new utility function |
| src/components/Shared/ResourceStatusCell.tsx | Updates timeAgo usage in status cell component |
| src/components/ControlPlane/ProvidersConfig.tsx | Updates timeAgo usage in providers configuration |
| src/components/ControlPlane/Providers.tsx | Updates timeAgo usage in providers list |
| src/components/ControlPlane/ManagedResources.tsx | Updates timeAgo usage in managed resources |
| src/components/ControlPlane/FluxList.tsx | Updates timeAgo usage in flux list component |
lucasgoral
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
formatDateAsTimeAgoas a replacement fortimeAgo.format(new Date(…)), so we can more gracefully handle transition times that are missing or formatted in unexpected ways.