-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor omero-server role (breaking changes) #8
Conversation
This ensures that if value begins with `-` it should be handled correctly
The changes document reads quite well, but I haven't been able to review all of them individually (in terms of naming etc). To some degree, we almost need a period of low-version numbers (omero-server2:0.1.0) to work through the API here before saying that this is stable. Anyone have suggestions on how to manage that? |
@sbesson we need some advice on naming versions 😄 |
@manics :) An alternative to #8 (comment) might be to maintain the same role name but express the fact we are working towards an API-breaking |
I don't know what the behaviour of tags is. If we're happy to test without tagged versions we could create a separate |
Last four commits:
|
Last commit uses https://pypi.python.org/pypi/ome-ansible-molecule-dependencies/ for bundling dependencies |
As discussed with @joshmoore and @manics, assuming there is no additional planned breaking change, I would vote for merging this into master, tag it |
👍 |
This implements ome/design#73 in conjunction with
It also implements a variant of ome/design#70 using a systemd
ExecStartPre
script to reinitialise the omero configuration from a directory of*.omero
files.Major changes from version
1.*
of this role are outlined inCHANGES.md
.