-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATEST-349: Run 2.x E2E tests on chrome and firefox via github actions #485
Conversation
da20e3d
to
420ba31
Compare
f8dc2ea
to
be01851
Compare
3f42eb0
to
ba90cf8
Compare
Thanks @anjula-sack for pulling this up. Could you help me understand how this work? |
The strategy section defines a matrix strategy that allows the job to run multiple times with different configurations. In this case, the matrix specifies a variable browser with two possible values: firefox and chrome. This means that the job will run twice, once with browser set to firefox and once with browser set to chrome. |
The strategy looks great! Does this configuration overrides the global setting here? |
No, It just downloads the chrome selenuim driver and runs the tests. Basically everything is same as before we just have extra jobs to run tests on chrome |
So which browser is being used by the tests as per this commit? |
Both of them. Check the tests, you can see every test has been ran twice. One with chrome and the other with firefox. |
Have skimmed through the logs and noticed all the two jobs are running on firefox browser. Could you take a look at the logs to find out why this is happening so? What would happen when you switch browser order and begin with chrome?.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @anjula-sack . I added some comments
@kdaud Check now. It's running on both now. I had to update the properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thanks @anjula-sack
@anjula-sack, revert the changes that were made in the platform ui tests. |
Didn't get you? |
The platform ui tests should be excluded from the changes and that's why they're failing plans in master, look out for the .yaml files starting with |
Requirements
Summary
For a while RefApp 2.x e2e tests have been running on the Firefox browser in GitHub actions. In this PR the all the tests are being updated to run on chrome as well. This was achieved by updating the github actions workflows.
Screenshots
None.
Related Issue
https://issues.openmrs.org/browse/RATEST-349
Other
None.