TRUNK-5114 Using different logging implementations instead of facade #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace use of log4j with slf4j logging facade in PersonValidator * use parametrized message with log.debug which avoids superfluous object creation when the logger is disabled for the DEBUG level and removes if clause which causes a double check for wether DEBUG level is enabled
|
@teleivo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bmamlin, @samshuster and @djazayeri to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object creation when the logger is disabled for the DEBUG level and
removes if clause which causes a double check for wether DEBUG level is
enabled
Description
Related Issue
see https://issues.openmrs.org/browse/TRUNK-5114