Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5535:Upgrade org.codehaus Libraries #2942

Closed
wants to merge 1 commit into from
Closed

TRUNK-5535:Upgrade org.codehaus Libraries #2942

wants to merge 1 commit into from

Conversation

jwnasambu
Copy link
Contributor

Description of what I changed

I upgraded a sub Library org.codehaus.sonar-plugins.java:sonar-jacoco-listeners … 3.1 -> 3.2

Issue I worked on

https://issues.openmrs.org/browse/TRUNK-5535

@jwnasambu
Copy link
Contributor Author

@dkayiwa kindly review my work at your own convenience.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 59.82% when pulling c5cbf8f on jwnasambu:TRUNK-5535 into cb2acdc on openmrs:master.

@mozzy11
Copy link
Member

mozzy11 commented May 27, 2019

@jwnasambu looks fine

@mozzy11
Copy link
Member

mozzy11 commented May 27, 2019

cc @dkayiwa

@dkayiwa
Copy link
Member

dkayiwa commented May 27, 2019

@jwnasambu
Copy link
Contributor Author

@dkayiwa am sorry for taking long to respond to this PR. I just saw your comment today! I kindly need your clarification basing on the link you shared. The ticket requires me to upgrade JaCoCo Listeners sub library from version 3.1 -> 3.2 which I did and the build was successful. What am not understanding is if am supposed to upgrade to the latest version which is 5.14.0.18788. Kindly help me understand your commend. Thanks

@jwnasambu
Copy link
Contributor Author

@teleivo
Copy link
Member

teleivo commented Aug 7, 2020

@jwnasambu please compare the group I'd. the link you provides showas an artifact with a different group id we depend on

<groupId>org.codehaus.sonar-plugins.java</groupId>
				<artifactId>sonar-jacoco-listeners</artifactId>

@jwnasambu
Copy link
Contributor Author

@teleivo Thanks for the feedback! its unfortunate I didn't take a keen look at it after being refereed to the link by a reviewer.

@teleivo
Copy link
Member

teleivo commented Aug 7, 2020

How different is it from this? https://mvnrepository.com/artifact/org.sonarsource.java/sonar-jacoco-listeners

are you suggesting that we switch to the artifact you posted? since its not the one we are using.

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare!

This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side.
Please note that this is an automated message and we might very well be the reason why there has not been any activity lately. We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs.

If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :)
If you would like to continue working on it or require help from us please remove the stale label and respond by commenting on the issue.

@github-actions github-actions bot added the Stale label Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

tl;dr closing this PR since it has not seen any activity in the last 6 months.

OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner.

Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :)

@github-actions github-actions bot closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants