-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRUNK-5535:Upgrade org.codehaus Libraries #2942
Conversation
@dkayiwa kindly review my work at your own convenience. |
@jwnasambu looks fine |
cc @dkayiwa |
How different is it from this? https://mvnrepository.com/artifact/org.sonarsource.java/sonar-jacoco-listeners |
@dkayiwa am sorry for taking long to respond to this PR. I just saw your comment today! I kindly need your clarification basing on the link you shared. The ticket requires me to upgrade JaCoCo Listeners sub library from version 3.1 -> 3.2 which I did and the build was successful. What am not understanding is if am supposed to upgrade to the latest version which is 5.14.0.18788. Kindly help me understand your commend. Thanks |
@jwnasambu please compare the group I'd. the link you provides showas an artifact with a different group id we depend on <groupId>org.codehaus.sonar-plugins.java</groupId>
<artifactId>sonar-jacoco-listeners</artifactId> |
@teleivo Thanks for the feedback! its unfortunate I didn't take a keen look at it after being refereed to the link by a reviewer. |
are you suggesting that we switch to the artifact you posted? since its not the one we are using. |
tl;dr our action detected no activity on this PR and will close it in 30 days if the stale label is not removed. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! This PR has not seen any activity in the last 5 months. That is why we wanted to check whether you are still working on it or need assistance from our side. If you do not have time to continue the work or have moved on you don’t need to do anything. We will automatically close the PR in 30 days. We hope to see you back soon :) |
tl;dr closing this PR since it has not seen any activity in the last 6 months. OpenMRS welcomes your contribution! It means a lot to us that you want to contribute to equity in healthcare! We certainly do not want to discourage you from contributing. We do need to be honest in that OpenMRS has limited resources for reviewing PRs. Your PR has not seen any activity in the last 6 months. This is why we have decided to close this PR for now. This allows us OpenMRS reviewers to focus our limited time to review all other PRs in a timely and professional manner. Please feel free to reassign yourself to the issue you worked on in our JIRA when you have time to focus on it. After that reopen a new PR and we will be glad to work with you to get your contribution merged. Thank you very much for your help and understanding :) |
Description of what I changed
I upgraded a sub Library org.codehaus.sonar-plugins.java:sonar-jacoco-listeners … 3.1 -> 3.2
Issue I worked on
https://issues.openmrs.org/browse/TRUNK-5535