TRUNK-5410: OrderGroupAttribute implementation #2986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include a link to the ticket as advised here? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
Can you also provide unit tests? |
|
you can also squash your commits |
isaaclin-artist
force-pushed
the
TRUNK-5410
branch
from
f4f0301
to
3291833
Compare
Thank you for advice. |
isaaclin-artist
force-pushed
the
TRUNK-5410
branch
from
3291833
to
408e162
Compare
|
@isaaclin-artist did you see the above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrderGroups will also be extended via attributes to associate cycle number, the total number of cycles in the regimen, and the length of the regimen cycles.
Please refer to this Talk post for more detail: https://talk.openmrs.org/t/chemotherapy-ordering-data-design/19133