Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk-5650:Add parent order group to order group #3068

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

gitcliff
Copy link
Contributor

@gitcliff gitcliff commented Dec 2, 2019

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage decreased (-0.006%) to 59.99% when pulling 4cfdd95 on gitcliff:Trunk-5650 into bfbc32a on openmrs:master.

@dkayiwa
Copy link
Member

dkayiwa commented Dec 9, 2019

Can you look into these merge conflicts?

@gitcliff
Copy link
Contributor Author

gitcliff commented Dec 9, 2019

@dkayiwa i have resolved the merge conflicts

@dkayiwa
Copy link
Member

dkayiwa commented Dec 12, 2019

Are these the only changes required by the ticket?

@gitcliff
Copy link
Contributor Author

@dkayiwa yes the changes are required by the ticket because changeset needs to be in a liquibase-update-to-2.4.xml file instead of liquibase-update-to-2.3.xml

@dkayiwa
Copy link
Member

dkayiwa commented Dec 13, 2019

Did you remove this changeset from the liquibase-update-to-2.3.xml file?

@gitcliff
Copy link
Contributor Author

gitcliff commented Dec 15, 2019

yes @dkayiwa, as you had earlier on requested in the comment on the ticket proceeding after the merge

@dkayiwa
Copy link
Member

dkayiwa commented Dec 18, 2019

@gitcliff are you sure that you did so?

@gitcliff
Copy link
Contributor Author

@dkayiwa i have fixed it

@dkayiwa dkayiwa merged commit 230a4a5 into openmrs:master Dec 19, 2019
prathamesh-mutkure pushed a commit to prathamesh-mutkure/openmrs-core that referenced this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants