OCLOMRS-1054:Avoid implying SYNONYM is a name type

[suruchee]

JIRA TICKET NAME:

Avoid implying SYNONYM is a name type

Summary:

Name type of Synonym is displayed at the top in grey italic text with a bracket

[ibacher]

Two simplifications:

Suggested change

	{nameType.label.includes("Synonym") ? (
	<div className={classes.menuItemSynonym}>
	({nameType.label})
	</div>
	) : (
	<div>{nameType.label}</div>
	)}
	<div className={nameType.label === "Synonym" && classes.menuItemSynonym}>
	({nameType.label})
	</div>

1. We only want this to apply to "Synonym" not "Custom Synonym" (since presumbably that needs some kind of value).
2. We can do this with a single div

[suruchee]

Hi @ibacher, I tried this with a single div but ended up with an error that says: Type 'string | false' is not assignable to type 'string | undefined'.   Type 'false' is not assignable to type 'string | undefined'.

[ibacher]

Try this expression instead:

nameType.label === "Synonym" ? classes.menuItemSynonym : undefined

[suruchee]

@ibacher , it's updated please have a look.

[ibacher]

I'm less sure about this... "Fully Specified" should definitely be the first option we display when creating a new name, so maybe we just don't change this for now?

[ibacher]

Incidentally, I think this is why there's a test failure. The test assumes that the first name entered is always a FSN and for any concept in any language we always require at least one FSN

[suruchee]

Thanks, for catching this test failure, I will revert it.

[ibacher]

I'm not sure about the font style. Also, since we use the Material Design System for this app, we should consult their guidelines about color. In particular, for disabled text, instead of adjusting the color directly, the Material guidelines suggest using 38% percent opacity.

That means this should probably be:

Suggested change

	color: "#A9A9A9",
	fontStyle: "italic"
	opacity: 0.38

[suruchee]

@ibacher, I have updated with your suggestions please have a look.

[coveralls]

Coverage decreased (-0.02%) to 46.634% when pulling 9a9a1cf on suruchee:OCLOMRS-1054 into da18b22 on openmrs:master.

[ibacher]

LGTM! Thanks @suruchee!