Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pages/aws/config/custom_overrides.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,10 @@ import type {
APIGatewayProxyEventV2,
APIGatewayProxyResultV2,
} from "aws-lambda";
import type { StreamCreator } from "@opennextjs/aws/http/openNextResponse.js";
import { Writable } from "node:stream";

import { WarmerEvent, WarmerResponse } from "@opennextjs/aws/adapters/warmer-function.js";
import type { StreamCreator } from "@opennextjs/aws/types/open-next.js";
import type { WrapperHandler } from "@opennextjs/aws/types/overrides.js";

type AwsLambdaEvent =
Expand Down Expand Up @@ -248,9 +248,6 @@ const handler: WrapperHandler =
},
});
},
onFinish: () => {
// Do nothing
},
};

const response = await handler(internalEvent, fakeStream);
Expand Down
2 changes: 1 addition & 1 deletion pages/aws/config/overrides/converter.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ If you want to better understand how to implement your own Converter, the easies
Couple of things to note :
- If you use a `StreamCreator` in your wrapper, you probably don't need to do anything in the `convertTo` function.
- If used for the default, the image optimization, or one of the splitted server the internal types will be `InternalEvent` and `InternalResult` respectively.
- If used for the external middleware, the internal types will be `InternalEvent` and `InternalResult | MiddlewareOutputEvent` respectively.
- If used for the external middleware, the internal types will be `InternalEvent` and `InternalResult | MiddlewareResult` respectively.
- For the other servers, look up their respective types in the codebase.
2 changes: 1 addition & 1 deletion pages/aws/contribute/local_run.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import express from 'express'
import proxy from 'express-http-proxy'
import { fork } from 'child_process'

import type { StreamCreator } from "@opennextjs/aws/http/openNextResponse.js";
import type { StreamCreator } from "@opennextjs/aws/types/open-next.js";
import type { WrapperHandler } from "@opennextjs/aws/types/overrides.js";

const wrapper: WrapperHandler = async (handler, converter) => {
Expand Down
Loading