fix: Ensure dynamic routes are excluded in getStaticAPIRoutes #1001
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8d4aba The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Oct 10, 2025
vicb
approved these changes
Oct 10, 2025
Merged
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opennextjs/opennextjs-cloudflare#942
As the filter currently was it only excluded static API routes that was excatly
"/api"and if that route was present indynamicRoutePages. We want to filter out every dynamic route.It caused an invalid regex runtime error if you had a route on
app/api/auth/[...better-auth]/route.tscause it wouldn't be excluded like it should, resulting in creating aRouteDefinitionwith an invalid regex due to unescaped hyphens.