Fix duplicated query params being sent to next from apigw v1 events #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1 event contain all params in multiValueQueryStringParameters
🦋 Changeset detectedLatest commit: d036071 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edvinerikson
changed the title
|
Thanks @edvinerikson! Released in v1.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 event contain all params in multiValueQueryStringParameters. Atm there is a bug where all params get duplicated in when sent to next.
eg an input path to the api gw:
/?step=1becomes/step=1&step=1after we reconstruct the query params from the v1 event. The solution in this PR i to just check the multiValueQueryStringParameters object as that one will be populated even in cases where there isn't any multi-values.