-
Notifications
You must be signed in to change notification settings - Fork 168
fix cookie redirect matcher #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+119
−2
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export default function RedirectDestination() { | ||
| return ( | ||
| <div> | ||
| <h1>I was redirected from next.config.js</h1> | ||
| <p>/next-config-redirect => /config-redirect</p> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
packages/tests-e2e/tests/appRouter/config.redirect.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { expect, test } from "@playwright/test"; | ||
| /** | ||
| * This tests that the "redirect" config in next.config.js works | ||
| * | ||
| * redirects: () => { | ||
| return [ | ||
| { | ||
| source: "/next-config-redirect", | ||
| destination: "/config-redirect", | ||
| permanent: true, | ||
| missing: [{ type: "cookie", key: "missing-cookie" }], | ||
| }, | ||
| ]; | ||
| }, | ||
| */ | ||
| test.describe("Next Config Redirect", () => { | ||
| test("Missing cookies", async ({ page }) => { | ||
| await page.goto("/"); | ||
| await page.goto("/next-config-redirect-missing"); | ||
|
|
||
| await page.waitForURL(`/config-redirect?missing=true`); | ||
|
|
||
| const el = page.getByText("I was redirected from next.config.js", { | ||
| exact: true, | ||
| }); | ||
| await expect(el).toBeVisible(); | ||
| }); | ||
| test("Not missing cookies", async ({ page }) => { | ||
| await page.goto("/"); | ||
| await page.goto("/next-config-redirect-not-missing"); | ||
|
|
||
| // the cookie was not missing, so no redirects | ||
| await page.waitForURL("/next-config-redirect-not-missing"); | ||
|
|
||
| const el = page.getByText("This page could not be found.", { | ||
| exact: true, | ||
| }); | ||
| await expect(el).toBeVisible(); | ||
| }); | ||
| test("Has cookies", async ({ page }) => { | ||
| await page.goto("/"); | ||
| await page.goto("/next-config-redirect-has"); | ||
|
|
||
| await page.waitForURL(`/config-redirect?has=true`); | ||
|
|
||
| const el = page.getByText("I was redirected from next.config.js", { | ||
| exact: true, | ||
| }); | ||
| await expect(el).toBeVisible(); | ||
| }); | ||
| test("Has cookies with value", async ({ page }) => { | ||
| await page.goto("/"); | ||
| await page.goto("/next-config-redirect-has-with-value"); | ||
|
|
||
| await page.waitForURL(`/config-redirect?hasWithValue=true`); | ||
|
|
||
| const el = page.getByText("I was redirected from next.config.js", { | ||
| exact: true, | ||
| }); | ||
| await expect(el).toBeVisible(); | ||
| }); | ||
| test("Has cookies with bad value", async ({ page }) => { | ||
| await page.goto("/"); | ||
| await page.goto("/next-config-redirect-has-with-bad-value"); | ||
|
|
||
| // did not redirect | ||
| await page.waitForURL(`/next-config-redirect-has-with-bad-value`); | ||
|
|
||
| // 404 not found | ||
| const el = page.getByText("This page could not be found.", { | ||
| exact: true, | ||
| }); | ||
| await expect(el).toBeVisible(); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conico974 Should this be updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be updated as well, but i think we should do something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!headers?.[redirect.key.toLowerCase()]should take care of both those conditions right?undefinedand empty string will both be false.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conico974 gonna merge this unless I should make your suggested changes.