Feat readable body #486
Merged
Feat readable body #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38a5df6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khuezy
approved these changes
Aug 7, 2024
|
|
||
| export function emptyReadableStream(): ReadableStream { | ||
| if (process.env.OPEN_NEXT_FORCE_NON_EMPTY_RESPONSE === "true") { | ||
| return Readable.toWeb(Readable.from(["SOMETHING"])); |
There was a problem hiding this comment.
Can this be an empty string or does it have to be a non-empty string?
There was a problem hiding this comment.
Empty string didn't work, we could have used new Uint8Array(8) but since it is used as a delimiter for the header part of the string i fear that this could introduce other issue later ( being misinterpreted by the streaming server )
conico974
commented
Aug 8, 2024
conico974
force-pushed
the
feat/readable-body
branch
from
f97b2e3 to
38a5df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the body of
InternalResultfromstringtoReadableStream.This allow for edge runtime function to use streaming, and it is necessary to prepare for PPR.
This should also remove the need to add a
fakeStreamin non streaming wrapper as the stream is now always consumed if you return a body.