Skip to content

Add unit tests for cache interceptor #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add unit tests for cache interceptor #577

merged 1 commit into from
Oct 21, 2024

Conversation

socsieng
Copy link
Contributor

@socsieng socsieng commented Oct 19, 2024 •
edited
Loading

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 404bb76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

conico974
conico974 reviewed Oct 19, 2024
View reviewed changes
@socsieng socsieng force-pushed the tests/cache-interceptor branch from 24bbbfc to b0402e5 Compare October 19, 2024 11:37
@socsieng socsieng requested a review from conico974 October 19, 2024 11:37
@socsieng socsieng force-pushed the tests/cache-interceptor branch from b0402e5 to 9823365 Compare October 19, 2024 11:45
conico974
conico974 reviewed Oct 19, 2024
View reviewed changes
@socsieng socsieng force-pushed the tests/cache-interceptor branch from 9823365 to 404bb76 Compare October 19, 2024 23:16
@socsieng socsieng requested a review from conico974 October 19, 2024 23:19
conico974
conico974 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.
Next time if you could avoid force pushing into the same commit it would be great. It makes review harder because i have to go through the whole PR everytime

@conico974 conico974 merged commit cd8d6f8 into opennextjs:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conico974 conico974 conico974 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@socsieng @conico974