-
Notifications
You must be signed in to change notification settings - Fork 174
chore: upgrade examples to next 15 and fix e2e test #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently failing on this when i |
Can you try reverting the changes to:
I'm using the 18.x |
Not able to build |
@sommeeeer There is an issue with the lockfile https://github.com/opennextjs/opennextjs-aws/actions/runs/11466288277/job/31906625766?pr=588 |
0ce2bc3
to
cb5053b
Compare
After installing What happend with the validation? I would like to know if the lockfile is fine now. For now im trying to stay on React 18 for |
So I think its using the wrong dependency for React for some reason. If this is related to |
|
ae77836
to
691f1d6
Compare
alright so im able to build every app now with i also changed the worldtimeapi to be timeapi instead. (worldtimeapi blocked me after a while) |
so i was able to run if you just wait it will finish in the end, and you will get the deployed urls. as you can see the warning is probably coming from a peer dependency of sst which is i fixed the e2e to work now and it passes 100% |
cb3b477
to
70bb0e1
Compare
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that @sommeeeer
yay thanks @sommeeeer ! |
This PR will be in draft mode. Trying to update all the apps in
/examples
to next 15 and fix the e2e test.