Skip to content

chore(e2e): Skip request.url is host when ran locally #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

chore(e2e): Skip request.url is host when ran locally #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
353f51b
chore(e2e): Skip request.url is host when ran locally
sommeeeer Aug 31, 2025
47ccdc1
refactor
sommeeeer Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/tests-e2e/tests/appPagesRouter/host.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ import { expect, test } from "@playwright/test";
* Tests that the request.url is the deployed host and not localhost
*/
test("Request.url is host", async ({ baseURL, page }) => {
// We skip this test when E2E is run locally with `http` as protocol.
// The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901
test.skip(
(baseURL ?? "").startsWith("http://localhost"),
"Skipping test on localhost",
);
await page.goto("/api/host");

const el = page.getByText(`{"url":"${baseURL}/api/host"}`);
Expand Down
6 changes: 6 additions & 0 deletions packages/tests-e2e/tests/appRouter/host.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ import { expect, test } from "@playwright/test";
* Tests that the request.url is the deployed host and not localhost
*/
test("Request.url is host", async ({ baseURL, page }) => {
// We skip this test when E2E is run locally with `http` as protocol.
// The cause can be seen here: https://github.com/opennextjs/opennextjs-aws/issues/969#issuecomment-3239569901
test.skip(
(baseURL ?? "").startsWith("http://localhost"),
"Skipping test on localhost",
);
await page.goto("/api/host");

const el = page.getByText(`{"url":"${baseURL}/api/host"}`);
Expand Down
Loading