-
Notifications
You must be signed in to change notification settings - Fork 172
chore(e2e): Add local E2E action to check workflow #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
a7a2900
to
c2f86f4
Compare
@sommeeeer what is the status here? |
It should be ready to go. |
1cda2e7
to
8a70e25
Compare
Tests do not work locally on MacOS. I'll go ahead and merge #985 as it is a pre-requisite. Then I'll amend this PR to address this comment Ok with you @sommeeeer ? |
Go for it Victor! |
fix order refactor check workflow order fs-dev-nextMode for experimental refactor env variable
commit: |
@sommeeeer The last fixup commit fixes the sharp related issues on Mac. There is still some flakyness with the ISR test locally. If you approve my change, I'll approve your PR, but no pressure 😅 |
I took a quick look at it, and for some reason this date is not equal according to the E2E on the initial run after build. It does work on every run after that. Even if you restart the server. We can dig into it at a later time. LGTM, perhaps add a comment about it being flakey on that line when ran locally before you merge. |
@sommeeeer I created #998 Let's merge this PR for now, it is super helpful to have an easy to run e2e tests. Thanks a lot for your work here! |
Thanks Victor, same to you! |
This PR will be the last missing piece for running the E2E locally in our
Validate merge requests
workflow.examples/*
apps on these ports: app-router=3001 pages-router=3002 app-pages-router=3003 experimental=3004. The command it uses ispnpm -r openbuild:local
to build andopenbuild:local:start
to start the servers.pnpm e2e:test
I also renamed the
pnpm-setup
action tosetup
.Here is a successful run on my fork (with the pending PRs)
Depends on #964 and #970
For this #958 (comment)