Skip to content

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Aug 31, 2025

This PR will be the last missing piece for running the E2E locally in our Validate merge requests workflow.

  • It will replace our current Playwright setup with its own action. The one we currently have had some error in its syntax, resulting in never providing a value to its output. Thus, it would never be cached. However, Playwright themselves do claim that you should not really cache. Let me know if I should change that.
  • It will build and run all the examples/* apps on these ports: app-router=3001 pages-router=3002 app-pages-router=3003 experimental=3004. The command it uses is pnpm -r openbuild:local to build and openbuild:local:start to start the servers.
  • After that it will run pnpm e2e:test

I also renamed the pnpm-setup action to setup.

Here is a successful run on my fork (with the pending PRs)

Depends on #964 and #970

For this #958 (comment)

Copy link

changeset-bot bot commented Aug 31, 2025

⚠️ No Changeset found

Latest commit: e1fb8fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sommeeeer sommeeeer changed the title chore(e2e): Add e2e-local action to check workflow chore(e2e): Add local E2E action to check workflow Aug 31, 2025
@sommeeeer sommeeeer marked this pull request as ready for review August 31, 2025 20:02
@vicb
Copy link
Contributor

vicb commented Oct 8, 2025

@sommeeeer what is the status here?

@sommeeeer
Copy link
Contributor Author

@sommeeeer what is the status here?

It should be ready to go.

@vicb
Copy link
Contributor

vicb commented Oct 9, 2025

Tests do not work locally on MacOS.

I'll go ahead and merge #985 as it is a pre-requisite.

Then I'll amend this PR to address this comment

Ok with you @sommeeeer ?

@sommeeeer
Copy link
Contributor Author

Go for it Victor!

sommeeeer and others added 4 commits October 9, 2025 18:13
Copy link

pkg-pr-new bot commented Oct 9, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@971

commit: e1fb8fa

@vicb
Copy link
Contributor

vicb commented Oct 9, 2025

@sommeeeer The last fixup commit fixes the sharp related issues on Mac. There is still some flakyness with the ISR test locally.

If you approve my change, I'll approve your PR, but no pressure 😅

@sommeeeer
Copy link
Contributor Author

sommeeeer commented Oct 9, 2025

The last fixup commit fixes the sharp related issues on Mac. There is still some flakyness with the ISR test locally.

If you approve my change, I'll approve your PR, but no pressure 😅

I took a quick look at it, and for some reason this date is not equal according to the E2E on the initial run after build. It does work on every run after that. Even if you restart the server. We can dig into it at a later time.

LGTM, perhaps add a comment about it being flakey on that line when ran locally before you merge.

@vicb
Copy link
Contributor

vicb commented Oct 9, 2025

@sommeeeer I created #998

Let's merge this PR for now, it is super helpful to have an easy to run e2e tests. Thanks a lot for your work here!

@vicb vicb merged commit e2cc022 into opennextjs:main Oct 9, 2025
3 checks passed
@sommeeeer
Copy link
Contributor Author

Thanks Victor, same to you!

@sommeeeer sommeeeer deleted the add-local-e2e branch October 9, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants