improve performance of streams #996
Merged
+59
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca06ec1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
anonrig
force-pushed
the
yagiz/optimize-streams
branch
from
c488a6d to
8dd3dd1
Compare
vicb
reviewed
Oct 8, 2025
vicb
reviewed
Oct 8, 2025
vicb
reviewed
Oct 8, 2025
vicb
reviewed
Oct 8, 2025
vicb
reviewed
Oct 8, 2025
vicb
reviewed
Oct 8, 2025
Co-authored-by: Victor Berchet <victor@suumit.com>
Co-authored-by: Victor Berchet <victor@suumit.com>
jasnell
reviewed
Oct 8, 2025
jasnell
reviewed
Oct 8, 2025
jasnell
reviewed
Oct 8, 2025
| const { done, value } = await reader.read(); | ||
| if (done) break; | ||
| chunks.push(value); | ||
| totalLength += value.length; |
There was a problem hiding this comment.
does there need to be validation that value actually is a typed array?
jasnell
reviewed
Oct 8, 2025
jasnell
reviewed
Oct 8, 2025
jasnell
reviewed
Oct 8, 2025
anonrig
force-pushed
the
yagiz/optimize-streams
branch
from
65810fe to
edbfbf6
Compare
jasnell
reviewed
Oct 8, 2025
anonrig
force-pushed
the
yagiz/optimize-streams
branch
from
edbfbf6 to
3d21628
Compare
anonrig
force-pushed
the
yagiz/optimize-streams
branch
from
3d21628 to
ca06ec1
Compare
jasnell
reviewed
Oct 8, 2025
|
@conico974 would you mind landing this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overally reduces unnecessary allocations/copies.