Skip to content

Conversation

james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Feb 26, 2025

The typescript and eslint checks slow down our e2e builds while providing zero value. I would like to propose disabling them completely. The e2es we copied from aws already do this.

It's not a significant gain, but it cuts off about 15-20 seconds from time spent building apps.

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 1d310d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Feb 26, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@421

commit: 1d310d2

@james-elicx james-elicx marked this pull request as ready for review February 26, 2025 19:36
@vicb
Copy link
Contributor

vicb commented Feb 26, 2025

I agree it's worth running those each time.

Maybe running them "sometimes" can have some value (locally vs CI, first day of the week, randomly).

WDYT

@james-elicx
Copy link
Collaborator Author

I agree it's worth running those each time.

Maybe running them "sometimes" can have some value (locally vs CI, first day of the week, randomly).

WDYT

I think it would make more sense to run them as part of the lint/ts:check/format workflow if we want to keep them instead of relying on the app build

@vicb vicb merged commit 6b406cc into main Feb 27, 2025
7 checks passed
@vicb vicb deleted the james/disable-ts-and-eslint branch February 27, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants