chore: separate getNextConfig()
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
* feat: build time edge runtime * chore: update middleware test fixture * fix: remove pattern array for now * chore: update tests with middleware scenarios * chore: fix fixture build errors * feat: support edge middleware * chore: update comment * chore: remove `.only` * fix: stop caching resolved paths * chore: fix test * chore: add e2e test * fix: use correct runtime directory * chore: add E2E test * Apply suggestions from code review Co-authored-by: Lukas Holzer <lukas.holzer@typeflow.cc> * chore: remove dead code * chore: document `E2E_PERSIST` --------- Co-authored-by: Rob Stanford <me@robstanford.com> Co-authored-by: Lukas Holzer <lukas.holzer@typeflow.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #79
This separates
getNextConfig()so it can be re-used (at the moment, this code is present in two different places).In a follow-up PR, I will remove the duplicate code at https://github.com/netlify/netlify-plugin-nextjs/blob/main/src/lib/helpers/getNextConfig.js